SHellcheck compliance updates.

deployment/btcpayserver/remote_scripts/btcpay-restore.sh

@@ -3,25 +3,25 @@
 set -o pipefail -o errexit -x
 
 if [ "$(id -u)" != "0" ]; then
-  printf "\n🚨 This script must be run as root.\n"
-  printf "➡️ Use the command 'sudo su -' (include the trailing hypen) and try again.\n\n"
+  echo "ERROR: This script must be run as root."
+  echo "➡️ Use the command 'sudo su -' (include the trailing hypen) and try again."
   exit 1
 fi
 
 backup_path=$1
 if [ -z "$backup_path" ]; then
-  printf "\nℹ️ Usage: btcpay-restore.sh /path/to/backup.tar.gz\n\n"
+  echo "ERROR: Usage: btcpay-restore.sh /path/to/backup.tar.gz"
   exit 1
 fi
 
 if [ ! -f "$backup_path" ]; then
-  printf "\n🚨 $backup_path does not exist.\n\n"
+  echo "ERROR: $backup_path does not exist."
   exit 1
 fi
 
 if [[ "$backup_path" == *.gpg && -z "$BTCPAY_BACKUP_PASSPHRASE" ]]; then
-  printf "\n🔐 $backup_path is encrypted. Please provide the passphrase to decrypt it."
-  printf "\nℹ️ Usage: BTCPAY_BACKUP_PASSPHRASE=t0pSeCrEt btcpay-restore.sh /path/to/backup.tar.gz.gpg\n\n"
+  echo "INFO: $backup_path is encrypted. Please provide the passphrase to decrypt it."
+  echo "INFO: Usage: BTCPAY_BACKUP_PASSPHRASE=t0pSeCrEt btcpay-restore.sh /path/to/backup.tar.gz.gpg"
   exit 1
 fi
 
@@ -32,103 +32,87 @@ dbdump_name=postgres.sql.gz
 btcpay_dir="$BTCPAY_BASE_DIRECTORY/btcpayserver-docker"
 
 # ensure clean restore dir
-printf "\nℹ️ Cleaning restore directory $restore_dir …\n\n"
-rm -rf $restore_dir
-mkdir -p $restore_dir
+echo "INFO: Cleaning restore directory $restore_dir."
+rm -rf "$restore_dir"
+mkdir -p "$restore_dir"
 
 if [[ "$backup_path" == *.gpg ]]; then
   echo "🔐 Decrypting backup file …"
   {
-    gpg -o "${backup_path%.*}" --batch --yes --passphrase "$BTCPAY_BACKUP_PASSPHRASE" -d $backup_path
+    gpg -o "${backup_path%.*}" --batch --yes --passphrase "$BTCPAY_BACKUP_PASSPHRASE" -d "$backup_path"
     backup_path="${backup_path%.*}"
-    printf "✅ Decryption done.\n\n"
+    echo "SUCESS: Decryption done."
   } || {
     echo "🚨 Decryption failed. Please check the error message above."
     exit 1
   }
 fi
 
-cd $restore_dir
+cd "$restore_dir"
 
 echo "ℹ️ Extracting files in $(pwd) …"
-tar -h -xvf $backup_path -C $restore_dir
+tar -h -xvf "$backup_path" -C "$restore_dir"
 
 # basic control checks
 if [ ! -f "$dbdump_name" ]; then
-  printf "\n🚨 $dbdump_name does not exist.\n\n"
+  echo "ERROR: '$dbdump_name' does not exist."
   exit 1
 fi
 
 if [ ! -d "volumes" ]; then
-  printf "\n🚨 volumes directory does not exist.\n\n"
+  echo "ERROR: volumes directory does not exist."
   exit 1
 fi
 
-cd $btcpay_dir
+cd "$btcpay_dir"
 . helpers.sh
 
-printf "\nℹ️ Stopping BTCPay Server …\n\n"
-btcpay_down
+#echo "INFO: Stopping BTCPay Server."
+#btcpay_down
 
-cd $restore_dir
+cd "$restore_dir"
 
 {
-  printf "\nℹ️ Restoring volumes …\n"
+  echo "INFO: Restoring volumes."
   # ensure volumes dir exists
   if [ ! -d "$docker_dir/volumes" ]; then
-    mkdir -p $docker_dir/volumes
+    mkdir -p "$docker_dir/volumes"
   fi
   # copy volume directories over
-  cp -r volumes/* $docker_dir/volumes/
+  cp -r volumes/* "$docker_dir/volumes/"
   # ensure datadirs excluded in backup exist
-  mkdir -p $docker_dir/volumes/generated_postgres_datadir/_data
+  mkdir -p "$docker_dir/volumes/generated_postgres_datadir/_data"
   echo "✅ Volume restore done."
 } || {
   echo "🚨  Restoring volumes failed. Please check the error message above."
-  printf "\nℹ️ Restarting BTCPay Server …\n\n"
-  cd $btcpay_dir
-  btcpay_up
   exit 1
 }
 
 {
-  printf "\nℹ️ Starting database container …\n"
-  docker-compose -f $BTCPAY_DOCKER_COMPOSE up -d postgres
+  echo "INFO: Starting database container"
+  docker-compose -f "$BTCPAY_DOCKER_COMPOSE" up -d postgres
   dbcontainer=$(docker ps -a -q -f "name=postgres")
   if [ -z "$dbcontainer" ]; then
-    echo "🚨 Database container could not be started or found."
-    printf "\nℹ️ Restarting BTCPay Server …\n\n"
-    cd $btcpay_dir
-    btcpay_up
+    echo "ERROR: Database container could not be started or found."
     exit 1
   fi
 } || {
-  echo "🚨 Starting database container failed. Please check the error message above."
-  printf "\nℹ️ Restarting BTCPay Server …\n\n"
-  cd $btcpay_dir
-  btcpay_up
+  echo "ERROR: Starting database container failed. Please check the error message above."
   exit 1
 }
 
-cd $restore_dir
+cd "$restore_dir"
 
 {
-  printf "\nℹ️ Restoring database …"
-  gunzip -c $dbdump_name | docker exec -i $dbcontainer psql -U postgres postgres -a
-  echo "✅ Database restore done."
+  echo "INFO: Restoring database..."
+  gunzip -c $dbdump_name | docker exec -i "$dbcontainer" psql -U postgres postgres -a
+  echo "SUCCESS: Database restore done."
 } || {
-  echo "🚨 Restoring database failed. Please check the error message above."
-  printf "\nℹ️  Restarting BTCPay Server …\n\n"
-  cd $btcpay_dir
-  btcpay_up
+  echo "ERROR: Restoring database failed. Please check the error message above."
   exit 1
 }
 
-printf "\nℹ️ Restarting BTCPay Server …\n\n"
-cd $btcpay_dir
-btcpay_up
+echo "INFO: Cleaning up."
+rm -rf "$restore_dir"
 
-printf "\nℹ️ Cleaning up …\n\n"
-rm -rf $restore_dir
-
-printf "✅ Restore done\n\n"
+echo "SUCCESS: Restore done"